Allow future flag warning supression with explicit false setting (#10358

)
remix-run · Dec 20, 2024 · 16cd6d6 · 16cd6d6
1 parent 7f401df
commit 16cd6d6
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 19 deletions.
diff --git a/.changeset/curly-comics-bake.md b/.changeset/curly-comics-bake.md
@@ -0,0 +1,5 @@
+---
+"@remix-run/dev": patch
+---
+
+Allow supression of future flag warnings by setting them to `false`
diff --git a/packages/remix-dev/config.ts b/packages/remix-dev/config.ts
@@ -882,37 +882,37 @@ function logFutureFlagWarning(args: { flag: string; message: string }) {
 }
 
 export function logFutureFlagWarnings(future: FutureConfig) {
-  if (!future.v3_fetcherPersist) {
+  if (future.v3_fetcherPersist === undefined) {
     logFutureFlagWarning({
       flag: "v3_fetcherPersist",
       message: "Fetcher persistence behavior is changing in React Router v7",
     });
   }
 
-  if (!future.v3_lazyRouteDiscovery) {
+  if (future.v3_lazyRouteDiscovery === undefined) {
     logFutureFlagWarning({
       flag: "v3_lazyRouteDiscovery",
       message:
         "Route discovery/manifest behavior is changing in React Router v7",
     });
   }
 
-  if (!future.v3_relativeSplatPath) {
+  if (future.v3_relativeSplatPath === undefined) {
     logFutureFlagWarning({
       flag: "v3_relativeSplatPath",
       message:
         "Relative routing behavior for splat routes is changing in React Router v7",
     });
   }
 
-  if (!future.v3_singleFetch) {
+  if (future.v3_singleFetch === undefined) {
     logFutureFlagWarning({
       flag: "v3_singleFetch",
       message: "Data fetching is changing to a single fetch in React Router v7",
     });
   }
 
-  if (!future.v3_throwAbortReason) {
+  if (future.v3_throwAbortReason === undefined) {
     logFutureFlagWarning({
       flag: "v3_throwAbortReason",
       message:

diff --git a/packages/remix-react/package.json b/packages/remix-react/package.json
@@ -21,8 +21,8 @@
   "dependencies": {
     "@remix-run/router": "1.21.0",
     "@remix-run/server-runtime": "workspace:*",
-    "react-router": "6.28.1-pre.0",
-    "react-router-dom": "6.28.1-pre.0",
+    "react-router": "6.28.1",
+    "react-router-dom": "6.28.1",
     "turbo-stream": "2.4.0"
   },
   "devDependencies": {

diff --git a/packages/remix-testing/package.json b/packages/remix-testing/package.json
@@ -22,7 +22,7 @@
     "@remix-run/node": "workspace:*",
     "@remix-run/react": "workspace:*",
     "@remix-run/router": "1.21.0",
-    "react-router-dom": "6.28.1-pre.0"
+    "react-router-dom": "6.28.1"
   },
   "devDependencies": {
     "@remix-run/server-runtime": "workspace:*",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml