refactor(dev): rename onBuildFailure to onCompileFailure

remix-run · Oct 27, 2022 · 225bdea · 225bdea
1 parent 9d36189
commit 225bdea
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/packages/remix-dev/cli/commands.ts b/packages/remix-dev/cli/commands.ts
@@ -172,7 +172,7 @@ export async function build(
   await compiler.build(config, {
     mode,
     sourcemap,
-    onBuildFailure: (failure) => {
+    onCompileFailure: (failure) => {
       compiler.logCompileFailure(failure);
       throw Error();
     },

diff --git a/packages/remix-dev/compiler/build.ts b/packages/remix-dev/compiler/build.ts
@@ -11,15 +11,15 @@ export async function build(
     target = "node14",
     sourcemap = false,
     onWarning = warnOnce,
-    onBuildFailure = logCompileFailure,
+    onCompileFailure = logCompileFailure,
   }: Partial<CompileOptions> = {}
 ): Promise<void> {
   let compiler = createRemixCompiler(config, {
     mode,
     target,
     sourcemap,
     onWarning,
-    onBuildFailure,
+    onCompileFailure,
   });
-  await compile(compiler, { onCompileFailure: onBuildFailure });
+  await compile(compiler, { onCompileFailure });
 }
diff --git a/packages/remix-dev/compiler/options.ts b/packages/remix-dev/compiler/options.ts
@@ -25,5 +25,5 @@ export type CompileOptions = {
   target: Target;
   sourcemap: boolean;
   onWarning?: (message: string, key: string) => void;
-  onBuildFailure?: (failure: Error | esbuild.BuildFailure) => void;
+  onCompileFailure?: (failure: Error | esbuild.BuildFailure) => void;
 };
diff --git a/packages/remix-dev/compiler/watch.ts b/packages/remix-dev/compiler/watch.ts
@@ -34,7 +34,7 @@ export async function watch(
     target = "node14",
     sourcemap = true,
     onWarning = warnOnce,
-    onBuildFailure = logCompileFailure,
+    onCompileFailure = logCompileFailure,
     onRebuildStart,
     onRebuildFinish,
     onFileCreated,
@@ -47,7 +47,7 @@ export async function watch(
     mode,
     target,
     sourcemap,
-    onBuildFailure,
+    onCompileFailure,
     onWarning,
   };
 
@@ -65,7 +65,7 @@ export async function watch(
     try {
       config = await readConfig(config.rootDirectory);
     } catch (error) {
-      onBuildFailure(error as Error);
+      onCompileFailure(error as Error);
       return;
     }
 
@@ -77,7 +77,7 @@ export async function watch(
   let rebuild = debounce(async () => {
     onRebuildStart?.();
     let start = Date.now();
-    await compile(compiler, { onCompileFailure: onBuildFailure });
+    await compile(compiler, { onCompileFailure });
     onRebuildFinish?.(Date.now() - start);
   }, 100);
 
@@ -110,7 +110,7 @@ export async function watch(
       try {
         config = await readConfig(config.rootDirectory);
       } catch (error) {
-        onBuildFailure(error as Error);
+        onCompileFailure(error as Error);
         return;
       }