Refactor

remix-run · Feb 25, 2024 · 6b125cb · 6b125cb
1 parent 6ea2a38
commit 6b125cb
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/packages/remix-dev/vite/plugin.ts b/packages/remix-dev/vite/plugin.ts
@@ -774,15 +774,12 @@ export const remixVitePlugin: RemixVitePlugin = (remixUserConfig = {}) => {
     return new Set([...cssUrlPaths, ...chunkAssetPaths]);
   };
 
-  let getClientBuildAssetsDirectory = () => {
-    invariant(viteConfig);
-    return viteConfig.build.assetsDir;
-  };
-
   let generateRemixManifestsForBuild = async (): Promise<{
     remixBrowserManifest: RemixManifest;
     remixServerManifest: RemixManifest;
   }> => {
+    invariant(viteConfig);
+
     let viteManifest = await loadViteManifest(
       getClientBuildDirectory(ctx.remixConfig)
     );
@@ -838,8 +835,8 @@ export const remixVitePlugin: RemixVitePlugin = (remixUserConfig = {}) => {
 
     let fingerprintedValues = { entry, routes: browserRoutes };
     let version = getHash(JSON.stringify(fingerprintedValues), 8);
-    let manifestPath = path.join(
-      getClientBuildAssetsDirectory(),
+    let manifestPath = path.posix.join(
+      viteConfig.build.assetsDir,
       `manifest-${version}.js`
     );
     let url = `${ctx.remixConfig.publicPath}${manifestPath}`;