Apply suggestions from code review

Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Christian Köberl <derkoe@users.noreply.github.com>
remix-run · Aug 20, 2022 · 8e94a44 · 8e94a44
1 parent a2ffdf0
commit 8e94a44
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 8 deletions.
diff --git a/packages/remix-azure-functions/server.ts b/packages/remix-azure-functions/server.ts
@@ -41,7 +41,7 @@ export function createRequestHandler({
 
   return async (_context: Context, req: HttpRequest) => {
     let request = createRemixRequest(req);
-    let loadContext = getLoadContext ? getLoadContext(req) : undefined;
+    let loadContext = getLoadContext?.(req);
 
     let response = (await handleRequest(
       request as unknown as Request,

diff --git a/templates/azure-functions/.nvmrc b/templates/azure-functions/.nvmrc
@@ -1 +1 @@
-16
+14
diff --git a/templates/azure-functions/package.json b/templates/azure-functions/package.json
@@ -2,14 +2,13 @@
   "scripts": {
     "build": "remix build",
     "dev": "swa start ./public --run \"remix dev\" --api-location .",
-    "postinstall": "func init --worker-runtime node --language typescript && remix setup azure-functions"
+    "postinstall": "func init --worker-runtime node --language typescript"
   },
   "dependencies": {
     "@remix-run/azure-functions": "*",
     "@remix-run/react": "*",
     "react": "^17.0.2",
-    "react-dom": "^17.0.2",
-    "remix": "*"
+    "react-dom": "^17.0.2"
   },
   "devDependencies": {
     "@azure/functions": "^3.0.0",

diff --git a/templates/azure-functions/public/staticwebapp.config.json b/templates/azure-functions/public/staticwebapp.config.json
@@ -1,11 +1,13 @@
 {
   "routes": [
     {
-      "route": "/",
-      "rewrite": "/api/azure"
+      "route": "/build/*"
+    },
+    {
+      "route": "/favicon.ico"
     },
     {
-      "route": "/index.html",
+      "route": "/*",
       "rewrite": "/api/azure"
     }
   ],