Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: graphql-api is missing required dependency "graphql" in package.json #3011

Closed
achinchen opened this issue Apr 28, 2022 · 0 comments · Fixed by #3042
Closed

Example: graphql-api is missing required dependency "graphql" in package.json #3011

achinchen opened this issue Apr 28, 2022 · 0 comments · Fixed by #3042
Labels
bug:unverified

Comments

@achinchen
Copy link
Contributor

achinchen commented Apr 28, 2022 •
edited
Loading

What version of Remix are you using?

1.4.2

Steps to Reproduce

  1. Clone the remix repo and cd to examples/graphql-api.
  2. Run yarn to install all dependencies.
  3. Run yarn dev and I got error message from console which is Error: Cannot find module 'graphql'.

Expected Behavior

graphql should be included in package.json to prevent the module missing.

Actual Behavior

graphql is not in package.json which causes the error happened.

Note

  • BTW the link in README.md L8 doesn't work.
  • I can do the PR to update both of them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug:unverified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(examples): add graphql to dependencies of graphql-api example
1 participant
@achinchen