Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(examples): add graphql to dependencies of graphql-api example #3042

Merged
merged 4 commits into from
May 2, 2022
Merged

docs(examples): add graphql to dependencies of graphql-api example #3042

merged 4 commits into from
May 2, 2022

Conversation

achinchen
Copy link
Contributor

Closes: #3011

  • Docs
  • Tests

Testing Strategy:

Test the changes in local via

cd expamples/graphql-api && yarn && yarn dev

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 1, 2022

Hi @achinchen,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 1, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title Fix/examples/graphql api dependency docs(examples): add graphql to dependencies of graphql-api example May 2, 2022
examples/graphql-api/README.md Outdated Show resolved Hide resolved
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to main May 2, 2022 11:45
@MichaelDeBoey MichaelDeBoey changed the base branch from main to dev May 2, 2022 11:45
@MichaelDeBoey
Copy link
Member

@achinchen Examples changes go against main.
Please rebase your branch onto main & set base branch to main as well.

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 2, 2022
@achinchen achinchen changed the base branch from dev to main May 2, 2022 12:16
@achinchen
Copy link
Contributor Author

achinchen commented May 2, 2022

@MichaelDeBoey
Done, plz have a look.

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label May 2, 2022
@MichaelDeBoey MichaelDeBoey merged commit bd1a0c6 into remix-run:main May 2, 2022
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 10, 2022
…ple (remix-run#3042)

* chore(examples/graphql-api): add graphql dependecy

* chore(examples/graphql-api): update environemnt link in README

* chore(contributors): sign CLA

* Update examples/graphql-api/README.md

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 12, 2022
…ple (remix-run#3042)

* chore(examples/graphql-api): add graphql dependecy

* chore(examples/graphql-api): update environemnt link in README

* chore(contributors): sign CLA

* Update examples/graphql-api/README.md

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 15, 2022
…ple (remix-run#3042)

* chore(examples/graphql-api): add graphql dependecy

* chore(examples/graphql-api): update environemnt link in README

* chore(contributors): sign CLA

* Update examples/graphql-api/README.md

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
aaronpowell pushed a commit to aaronpowell/remix that referenced this pull request May 16, 2022
…ple (remix-run#3042)

* chore(examples/graphql-api): add graphql dependecy

* chore(examples/graphql-api): update environemnt link in README

* chore(contributors): sign CLA

* Update examples/graphql-api/README.md

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example: graphql-api is missing required dependency "graphql" in package.json
3 participants