Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Javascript projects now include Typescript dependencies #5382

Closed
1 task done
unsivilaudio opened this issue Feb 7, 2023 · 3 comments
Closed
1 task done

[BUG] Javascript projects now include Typescript dependencies #5382

unsivilaudio opened this issue Feb 7, 2023 · 3 comments

Comments

@unsivilaudio
Copy link

What version of Remix are you using?

1.12.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

  • create new project with npx create-remix@latest myapp
  • select 'Just the basics' and 'Javascript'

Expected Behavior

Clean project with no mention of Typescript anywhere

Actual Behavior

tsconfig.json persists, and package.json includes all Typescript dependencies and "typescheck" script. I looked through the version changelogs, and this PR seems like the most likely culprit.

@pcattori
Copy link
Contributor

pcattori commented Feb 9, 2023

Removal of all Typescript-related code and config was unreliable and buggy since Remix doesn't control stuff outside of the app/ directory. Instead, Remix CLI now ensures that the app/ directory is rid of TS when selecting "Javascript".

For more, see our decision doc.

@pcattori pcattori closed this as completed Feb 9, 2023
@pcattori
Copy link
Contributor

pcattori commented Feb 9, 2023

As a separate issue, its probably worth updating the CLI prompt to make it clear that only the app/ directory is targeted for JS conversion.

@unsivilaudio
Copy link
Author

Thank you for your response. I originally thought maybe it was intentional but I couldn't find documentation to support that. Cheers and thanks for pointing me to that information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants