Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev): flat route fixes and enhancements #5228

Merged
merged 16 commits into from
Feb 6, 2023
Merged

fix(remix-dev): flat route fixes and enhancements #5228

merged 16 commits into from
Feb 6, 2023

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Jan 23, 2023 •
edited
Loading

Signed-off-by: Logan McAnsh logan@mcan.sh

Closes: #5170
Closes: #5261
Closes: #5303
Closes: #5322
Closes: #5324
Closes: #5327

  • Docs
  • Tests

Testing Strategy:

updated current tests

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: d5750c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
remix Patch
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mcansh mcansh changed the title fix(remix-dev): flat route fixes fix(remix-dev): flat route fixes and enhancements Jan 24, 2023
@mcansh mcansh marked this pull request as ready for review January 24, 2023 17:35
@mcansh mcansh force-pushed the logan/flat-route-fixes branch 2 times, most recently from 50e9842 to 5d77e95 Compare January 24, 2023 17:41
@ryanflorence ryanflorence mentioned this pull request Jan 24, 2023
Closed
@mcansh mcansh changed the base branch from dev to release-next January 25, 2023 16:59
@mcansh mcansh linked an issue Jan 27, 2023 that may be closed by this pull request
Layout can't be located in folder with routing v2 #5261
Closed
1 task
This was linked to issues Jan 29, 2023
v2 route file naming: route file convention not reading route folders correctly #5303
Closed
Routing V2 sub-route outlet doesn't show embedded in parent route #5170
Closed
@mcansh
fix(remix-dev): flat route fixes
c7be168 
TODO: fix layout from being flagged as index route
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: flat route enhancements and bug fixes
8339fea 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: remove console.log
20cd8d2 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: routeId is already normalized to /
3d76164 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
Create tame-swans-burn.md
5cc4ed3
@mcansh
chore: dont include /index in route id
01e00e8 
useRouteLoaderData("routes/_landing") should work for "routes/_landing.tsx" and "routes/_landing/index.tsx"

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: pass id to defineRoute
95fd2bf 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: use posix sep for routeId
e87ea0b 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: update and share options
3184f43 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: remove regex!
29bd3d6 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
fix: escaping _index
1de5575 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: remove left over log
d5328c5 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
fix: one day i wont be haunted by windows path separators
9c1ce8d 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh
chore: reuse array'd routeMap
06e0367 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh mentioned this pull request Jan 30, 2023
Merged
@mcansh
chore: use normalizeSlash utility
397d55a 
Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh mcansh mentioned this pull request Jan 31, 2023
Closed
1 task
@mcansh mcansh linked an issue Jan 31, 2023 that may be closed by this pull request
1.12 ENOENT: no such file or directory referencing outes instead of routes #5322
Closed
1 task
@mcansh mcansh changed the base branch from release-next to dev February 6, 2023 18:23
@ryanflorence ryanflorence merged commit d5f95bd into dev Feb 6, 2023
@ryanflorence ryanflorence deleted the logan/flat-route-fixes branch February 6, 2023 18:27
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Feb 6, 2023
This was referenced Feb 6, 2023
Closed
Closed
Closed
Closed
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-a024557-20230207 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@silvenon
Copy link
Contributor

silvenon commented Feb 7, 2023

Fixed my issues perfectly! ❤️

@unsivilaudio unsivilaudio mentioned this pull request Feb 7, 2023
Closed
1 task
@MajorTom327
Copy link

Same for me. Perfect !
Good job team ! 🎉

This was referenced Feb 7, 2023
Merged
Merged
TooTallNate added a commit to vercel/vercel that referenced this pull request Feb 23, 2023
@TooTallNate
[remix] Update @remix-run/dev dep to v1.13.0
7631991 
There were some fixes to thier new v2 filesystem routing that this will
help with.

Related to remix-run/remix#5322 and remix-run/remix#5228.
@TooTallNate TooTallNate mentioned this pull request Feb 23, 2023
Merged
kodiakhq bot pushed a commit to vercel/vercel that referenced this pull request Feb 23, 2023
@TooTallNate
[remix] Update @remix-run/dev dep to v1.13.0 (#9519)
73d6f0d 
There were some fixes to thier new v2 filesystem routing that this will help with.

Related to remix-run/remix#5322 and remix-run/remix#5228.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanflorence ryanflorence Awaiting requested review from ryanflorence

Assignees
No one assigned
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed package:dev
Projects
None yet
Milestone
No milestone
5 participants
@mcansh @silvenon @MajorTom327 @ryanflorence @MichaelDeBoey