Flat routes are broken on macOS (and probably Linux) in 1.12.0

[haines]

What version of Remix are you using?

1.12.0

Are all your remix dependencies & dev-dependencies using the same version?

• Yes

Steps to Reproduce

Set future.v2_routeConvention = true, attempt to build app on macOS.

Expected Behavior

Routes are loaded, build succeeds

Actual Behavior

Build breaks when loading routes

ENOENT: no such file or directory, open '<root>/app/outes/<route file>'

Note it is trying to load from outes not routes!

The bug was introduced in #5266. By splitting and rejoining the paths, it drops the leading /, converting /Users/me/... to Users/me/.... However appDirectory still has a leading / so removing directory prefixes with slice drops one too many characters.

[machour]

Maybe related to #5322 (the outes thingy)

[haines]

Workaround using patch-package:

patches/@remix-run+dev+1.12.0.patch:

diff --git a/node_modules/@remix-run/dev/dist/config/flat-routes.js b/node_modules/@remix-run/dev/dist/config/flat-routes.js
index e3646a7..52c0688 100644
--- a/node_modules/@remix-run/dev/dist/config/flat-routes.js
+++ b/node_modules/@remix-run/dev/dist/config/flat-routes.js
@@ -33,7 +33,7 @@ function flatRoutes(appDirectory, ignoredFilePatterns) {
   // fast-glob will return posix paths even on windows
   // convert posix to os specific paths
   let routePathsForOS = routePaths.map(routePath => {
-    return path__default["default"].join(...routePath.split(path__default["default"].posix.sep));
+    return path__default["default"].normalize(routePath);
   });
   return flatRoutesUniversal(appDirectory, routePathsForOS);
 }

[haines]

Duplicate of #5322

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-a024557-20230207 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!