Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude node_modules from tsconfig #6403

Closed
1 task done
rolanday opened this issue May 16, 2023 · 2 comments
Closed
1 task done

Exclude node_modules from tsconfig #6403

rolanday opened this issue May 16, 2023 · 2 comments

Comments

@rolanday
Copy link

What version of Remix are you using?

1.16.0

Are all your remix dependencies & dev-dependencies using the same version?

  • Yes

Steps to Reproduce

  1. npx create-remix@latest
  2. Y for typescript
  3. npm install
  4. npm run typecheck

Expected Behavior

Typecheck succeeds for new project

Actual Behavior

Typecheck fails

Fixed by updating tsconfig.json to include following entries:

...
  "exclude": ["node_modules"],
  "compilerOptions": {
      "skipLibCheck": true,

...

Or recommend addressing module type errors so clean remix starter typechecks clean.

Thank you,

lpsinger added a commit to lpsinger/remix that referenced this issue May 23, 2023
@lpsinger
Copy link
Contributor

Yeah, I think the best solution is to just revert #6051.

@markdalgleish
Copy link
Member

Closing as a duplicate of #4371.

@markdalgleish markdalgleish moved this from Backlog to Closed in v2 Aug 7, 2023
MichaelDeBoey pushed a commit to lpsinger/remix that referenced this issue Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Closed
Development

No branches or pull requests

4 participants