CDN Causing infinite reload

[yarbsemaj]

What version of Remix are you using?

1.18.0

Are all your remix dependencies & dev-dependencies using the same version?

• Yes

Steps to Reproduce

1. Place your site behind a CDN, and don't include query params in the cache key, but forward them to the origin
2. Visit a page with a cache header with query param, then again without
3. Page gets stuck in a infinite reload loop

Issue caused by this PR
#6409

Expected Behavior

Page should not get stuck in a loop and should load normally

Actual Behavior

Page gets stuck in an infinite reload loop as the url on the cache page does not match the URL of the page you are loading

[n8agrin]

@brophdawg11 I think we should drop the search comparison part of #6409.

@yarbsemaj that would fix your issue, right?

I can open a pr today

[yarbsemaj]

It should do, yes

[n8agrin]

@yarbsemaj see comment here: #6707 (comment)

[tatemz]

I also have seen infinite reloads when upgrading to 1.18, but I have not yet been able to confirm why. I see infinite reloading when running locally and not behind a CDN. As a result, my current project will remain on lower versions until I can figure out why 1.18 caused this issue

[brophdawg11]

I think #6707 is the correct fix here for CDN's ignoring search params so we're going to look into a patch release with that in it.

@tatemz Please reply if you can figure out your issue. Turn on Preserve log in the Look in the Chrome dev tools console settings and look for this type of message indicating Remix is reloading due to a mismatch:

Another root cause we identified was mismatched versions of @remix-run/server-runtime and @remix-run/react so ensure that those are the same version and you don't have duplicates (via npm ls [package])

[github-actions]

🤖 Hello there,

We just published version 1.18.1-pre.0 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[brophdawg11]

This should be available in 1.18.1 once released, but can be tested in 1.18.1-pre.0 currently.

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-0657c16-20230630 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[tatemz]

I think #6707 is the correct fix here for CDN's ignoring search params so we're going to look into a patch release with that in it.

@tatemz Please reply if you can figure out your issue. Turn on Preserve log in the Look in the Chrome dev tools console settings and look for this type of message indicating Remix is reloading due to a mismatch:

Another root cause we identified was mismatched versions of @remix-run/server-runtime and @remix-run/react so ensure that those are the same version and you don't have duplicates (via npm ls [package])

Thanks @brophdawg11. My project is definitely showing this error in the console. Thanks for the lead. I am using Shopify Hydrogen and will have to track down the deps resolution through their repo

[brophdawg11]

@tatemz yeah we chatted with the Hydrogen team yesterday about that. The issue boils down to hydrogen having an internal dependency on 1.17.1 but if you then update to 1.18.0 in your package.json, you can get a mismatch which causes this issue. For now just make sure you've installed the same remix versions as hydrogen is using internally. And then bump to 1.18.0 when they do. We discussed plans to avoid this type of mismatch in the future as well.

[github-actions]

🤖 Hello there,

We just published version 1.18.1-pre.2 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 1.18.1 which involves this issue. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!