-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-react): add event type to useBeforeUnload
#1723
Conversation
Hi @Runner-dev, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@Runner-dev could you add yourself to https://github.com/remix-run/remix/blob/main/contributors.yml ? |
looks like they did never mind, i think the dev merge removed it 🙈 |
useBeforeUnload
@Runner-dev Could you please rebase your branch onto |
🤖 Hello there, We just published version Thanks! |
Add event type to onBeforeUnload allowing it to be used in typescript code without errors
Fixes issue #1719