docs: remove misleading information about cache purge on file change #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 10, 2022
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 12, 2022
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 15, 2022
aaronpowell
pushed a commit
to aaronpowell/remix
that referenced
this pull request
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the changes introduced by #431, the documentation about purging the require cache is not accurate anymore and causes confusion, see #1832 and #1818 . Instead of purging the cache when files change, it is purged for every request.
See here for implementation:
remix/packages/remix-dev/cli/commands.ts
Line 171 in 2c2d5ab
This PR updates the documentation by removing incorrect statements and points out that the require cache is purged for every request.