Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Cli cleanup #2375

Merged
merged 3 commits into from
Mar 18, 2022
Merged

chore: Cli cleanup #2375

merged 3 commits into from
Mar 18, 2022

Conversation

mjackson
Copy link
Member

No need to use a shell to execute remix-dev. Instead, export the CLI interface from remix-dev and use it directly in create-remix.

No need to use a shell to execute remix-dev
Copy link
Collaborator

@mcansh mcansh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 i love it

@kentcdodds
Copy link
Member

Looks like there's a merge conflict.

@chaance chaance merged commit 4986844 into dev Mar 18, 2022
@MichaelDeBoey MichaelDeBoey deleted the cli-cleanup branch March 18, 2022 16:10
jstafman pushed a commit to jstafman/remix that referenced this pull request Mar 18, 2022
Use remix-dev directly in create-remix (No need to use a shell to execute remix-dev)

Co-authored-by: Chance Strickland <hi@chance.dev>
@mcansh
Copy link
Collaborator

mcansh commented Mar 21, 2022

i just noticed with this that create-remix now requires create-remix create to work

handled via #2431

MichaelDeBoey pushed a commit to TheRealAstoo/remix that referenced this pull request Mar 21, 2022
Use remix-dev directly in create-remix (No need to use a shell to execute remix-dev)

Co-authored-by: Chance Strickland <hi@chance.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants