fix: cli no longer crashes on syntax errors #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: print syntax error location
jacob-ebey
deleted the
jacob/rem-180-better-error-handling-in-the-compiler
branch
kentcdodds
reviewed
Aug 10, 2021
| @@ -78,7 +78,8 @@ export async function createAssetsManifest( | |||
| module: resolveUrl(key), | |||
| imports: resolveImports(output.imports) | |||
| }; | |||
| } else { | |||
| // Only parse routes otherwise dynamic imports can fall into here and fail the build | |||
| } else if (output.entryPoint.startsWith("browser-route-module:")) { | |||
There was a problem hiding this comment.
I just tested this change and it works great for me 👍 I can now use dynamic imports for native ESM modules 👏👏👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: print syntax error location