-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(remix-cloudflare): rename createCloudflareKVSessionStorage
to createWorkersKVSessionStorage
#2542
feat(remix-cloudflare): rename createCloudflareKVSessionStorage
to createWorkersKVSessionStorage
#2542
Conversation
createCloudflareKVSessionStorage
to createWorkersKVSessionStorage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we deprecate createCloudflareKVSessionStorage
as part of this PR?
@mjackson We should probably also add Lines 81 to 84 in 0d681e3
remix/packages/remix-eslint-config/rules/packageExports.js Lines 60 to 63 in 536b326
|
@mjackson It seems like we have some conflicts to resolve here |
4d64a8c
to
64f490c
Compare
🦋 Changeset detectedLatest commit: e151816 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
createCloudflareKVSessionStorage
to createWorkersKVSessionStorage
createCloudflareKVSessionStorage
to createWorkersKVSessionStorage
createCloudflareKVSessionStorage
to createWorkersKVSessionStorage
createCloudflareKVSessionStorage
to createWorkersKVSessionStorage
@mjackson I took the liberty of resolving all conversations here, so we can get this one merged |
4ab9de1
to
cd45f46
Compare
9740983
to
38f5ead
Compare
38f5ead
to
5c74477
Compare
51184c8
to
e733fc0
Compare
e733fc0
to
cca5563
Compare
1472986
to
397d6b0
Compare
7149381
to
1a6a1f0
Compare
da070b0
to
b723402
Compare
17f8e26
to
cc9a0fc
Compare
cc9a0fc
to
dd94b72
Compare
dd94b72
to
7bdae5e
Compare
0332316
to
21835c3
Compare
21835c3
to
e151816
Compare
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Rename to
createWorkersKVSessionStorage
for consistency with the "Workers KV" product name.