Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-cloudflare): rename createCloudflareKVSessionStorage to createWorkersKVSessionStorage #2542

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

mjackson
Copy link
Member

@mjackson mjackson commented Mar 29, 2022

Rename to createWorkersKVSessionStorage for consistency with the "Workers KV" product name.

@mjackson mjackson requested a review from pcattori March 29, 2022 17:29
@MichaelDeBoey MichaelDeBoey changed the title chore: rename createcloudflarekvsessionstorage chore(remix-cloudflare,remix-cloudflare-pages,remix-cloudflare-workers): rename createCloudflareKVSessionStorage to createWorkersKVSessionStorage Mar 29, 2022
Copy link
Contributor

@pcattori pcattori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we deprecate createCloudflareKVSessionStorage as part of this PR?

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Apr 1, 2022

@mjackson We should probably also add createWorkersKVSessionStorage to packageExports.ts in both replace-remix-imports migration & eslint-config

cloudflare: {
value: [...defaultRuntimeExports.value, "createCloudflareKVSessionStorage"],
type: [...defaultRuntimeExports.type],
},

const cloudflareSpecificExports = {
value: ["createCloudflareKVSessionStorage"],
type: [],
};

@MichaelDeBoey
Copy link
Member

@mjackson It seems like we have some conflicts to resolve here

@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch from 4d64a8c to 64f490c Compare August 25, 2022 19:16
@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2022

🦋 Changeset detected

Latest commit: e151816

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/cloudflare Minor
@remix-run/cloudflare-pages Minor
@remix-run/cloudflare-workers Minor
create-remix Minor
remix Minor
@remix-run/architect Minor
@remix-run/css-bundle Minor
@remix-run/deno Minor
@remix-run/dev Minor
@remix-run/eslint-config Minor
@remix-run/express Minor
@remix-run/netlify Minor
@remix-run/node Minor
@remix-run/react Minor
@remix-run/serve Minor
@remix-run/server-runtime Minor
@remix-run/testing Minor
@remix-run/vercel Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title chore(remix-cloudflare,remix-cloudflare-pages,remix-cloudflare-workers): rename createCloudflareKVSessionStorage to createWorkersKVSessionStorage chore(remix-cloudflare): rename createCloudflareKVSessionStorage to createWorkersKVSessionStorage Aug 25, 2022
@MichaelDeBoey MichaelDeBoey changed the title chore(remix-cloudflare): rename createCloudflareKVSessionStorage to createWorkersKVSessionStorage feat(remix-cloudflare): rename createCloudflareKVSessionStorage to createWorkersKVSessionStorage Aug 25, 2022
@MichaelDeBoey
Copy link
Member

@mjackson I took the liberty of resolving all conversations here, so we can get this one merged

@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch from 4ab9de1 to cd45f46 Compare August 25, 2022 19:36
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch 2 times, most recently from 9740983 to 38f5ead Compare August 28, 2022 14:29
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch from 38f5ead to 5c74477 Compare September 3, 2022 16:38
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch 3 times, most recently from 51184c8 to e733fc0 Compare September 21, 2022 01:40
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch from e733fc0 to cca5563 Compare September 21, 2022 23:28
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch 2 times, most recently from 1472986 to 397d6b0 Compare October 20, 2022 20:50
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch 2 times, most recently from 7149381 to 1a6a1f0 Compare November 10, 2022 13:33
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch 2 times, most recently from da070b0 to b723402 Compare November 19, 2022 22:12
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch 4 times, most recently from 17f8e26 to cc9a0fc Compare December 7, 2022 20:02
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch from cc9a0fc to dd94b72 Compare December 8, 2022 02:46
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch from dd94b72 to 7bdae5e Compare December 21, 2022 18:41
@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch 2 times, most recently from 0332316 to 21835c3 Compare January 21, 2023 14:23
@MichaelDeBoey
Copy link
Member

@mcansh @pcattori Anything that's preventing us from merging this one?

@MichaelDeBoey MichaelDeBoey force-pushed the michael/rem-926-rename-createcloudflarekvsessionstorage branch from 21835c3 to e151816 Compare January 22, 2023 01:46
@pcattori pcattori merged commit ceb36ba into dev Jan 23, 2023
@pcattori pcattori deleted the michael/rem-926-rename-createcloudflarekvsessionstorage branch January 23, 2023 15:28
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 23, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-8346ace-20230124 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 30, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants