Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(remix-dev): default to "just the basics" #3078

Merged
merged 2 commits into from
May 17, 2022
Merged

chore(remix-dev): default to "just the basics" #3078

merged 2 commits into from
May 17, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented May 3, 2022

resolves #3000

Signed-off-by: Logan McAnsh logan@mcan.sh

Testing Strategy:

I ran the build and ran node ./build/node_modules/create-remix/cli.js, then i ran yarn test to make sure they all still passed

@mcansh mcansh added the feat:dx Issues related to the developer experience label May 3, 2022
@mcansh mcansh linked an issue May 3, 2022 that may be closed by this pull request
Suggestion: Default installation should point to "Just the Basics" by default #3000
Closed
@MichaelDeBoey
Copy link
Member

Maybe we could also add the following (like we do with install?

default: 'template',

@mcansh
Copy link
Collaborator Author

mcansh commented May 3, 2022

Maybe we could also add the following (like we do with install?

default: 'template',

that's how i originally had it, but i think it's better to have the default at the top

@MichaelDeBoey
Copy link
Member

@mcansh My suggestion was to have both, not one or the other.

@mcansh
Copy link
Collaborator Author

mcansh commented May 3, 2022 •
edited
Loading

@mcansh My suggestion was to have both, not one or the other.

oh sorry! 🙈 🤦

mcansh added 2 commits May 7, 2022 14:06
@mcansh @MichaelDeBoey
chore(remix-dev): default to "just the basics"
2f9f6d3 
resolves #3000

Signed-off-by: Logan McAnsh <logan@mcan.sh>
@mcansh @MichaelDeBoey
Update run.ts
7ca6d88
kentcdodds
kentcdodds approved these changes May 17, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good 👍

@kentcdodds kentcdodds merged commit 9e5cd6d into dev May 17, 2022
@kentcdodds kentcdodds deleted the logan/rem-1057 branch May 17, 2022 03:57
@machour machour mentioned this pull request May 17, 2022
Closed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-9e5cd6d-20220517 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@donavon donavon mentioned this pull request Jul 31, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Aug 1, 2022
Open
@donavon donavon mentioned this pull request Aug 1, 2022
Open
This was referenced Nov 28, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@kentcdodds kentcdodds kentcdodds approved these changes

@machour machour machour approved these changes

Assignees
No one assigned
Labels
CLA Signed feat:dx Issues related to the developer experience package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: Default installation should point to "Just the Basics" by default
4 participants
@mcansh @MichaelDeBoey @machour @kentcdodds