Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev): fix package manager detection #3109

Merged
merged 1 commit into from
May 9, 2022
Merged

fix(remix-dev): fix package manager detection #3109

merged 1 commit into from
May 9, 2022

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented May 6, 2022 •
edited
Loading

Some issues from the npm CLI prove that it should indeed be npm_config_user_agent instead of npm_user_agent:

Follow-up of #2562
Closes #3108

@MichaelDeBoey MichaelDeBoey requested a review from kentcdodds May 6, 2022 10:06
@MichaelDeBoey MichaelDeBoey force-pushed the fix-package-manager-detection branch 2 times, most recently from 74ded32 to ff866d3 Compare May 6, 2022 10:13
@MichaelDeBoey MichaelDeBoey linked an issue May 6, 2022 that may be closed by this pull request
Remix CLI does not properly detect package manager #3108
Closed
@MichaelDeBoey MichaelDeBoey force-pushed the fix-package-manager-detection branch 2 times, most recently from 30cc97b to 872a9d7 Compare May 7, 2022 00:12
@MichaelDeBoey MichaelDeBoey force-pushed the fix-package-manager-detection branch from 872a9d7 to 72323da Compare May 9, 2022 12:57
kentcdodds
kentcdodds approved these changes May 9, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this locally 👍

@kentcdodds kentcdodds merged commit 7703472 into remix-run:dev May 9, 2022
@MichaelDeBoey MichaelDeBoey deleted the fix-package-manager-detection branch May 9, 2022 22:31
@MichaelDeBoey MichaelDeBoey mentioned this pull request May 9, 2022
Closed
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-cbd996f-20220510 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

christophertrudel pushed a commit to christophertrudel/remix that referenced this pull request May 16, 2022
@MichaelDeBoey
fix(remix-dev): fix package manager detection (remix-run#3109)
4a51bad
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.5.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remix CLI does not properly detect package manager
2 participants
@MichaelDeBoey @kentcdodds