Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-dev): add watchGlobs config option #3185

Closed
wants to merge 1 commit into from
Closed

feat(remix-dev): add watchGlobs config option #3185

wants to merge 1 commit into from

Conversation

laibulle
Copy link

@laibulle laibulle commented May 13, 2022 •
edited
Loading

discussion

Closes: #

  • Docs
  • Tests

Testing Strategy:

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 13, 2022

Hi @guillaumebailleul,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@MichaelDeBoey MichaelDeBoey changed the title feat: add watchdir config feat(remix-dev): add watchGlobs config May 13, 2022
@MichaelDeBoey
Copy link
Member

@guillaumebailleul Code changes go against dev.
Could you please rebase your branch onto latest dev & set base branch to dev as well?

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label May 13, 2022
@laibulle
Copy link
Author

laibulle commented May 13, 2022 •
edited by MichaelDeBoey
Loading

Hey, thanks.

Anyway, I just found that this PR do exactly the same as mine. #2985

So I close it

@laibulle laibulle closed this May 13, 2022
@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label May 13, 2022
@MichaelDeBoey MichaelDeBoey added the duplicate This issue or pull request already exists label May 13, 2022
@MichaelDeBoey MichaelDeBoey changed the title feat(remix-dev): add watchGlobs config feat(remix-dev): add watchGlobs config option May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laibulle @MichaelDeBoey