Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(remix-dev): import .sql files as text #3190

Merged
merged 3 commits into from
Aug 3, 2022
Merged

feat(remix-dev): import .sql files as text #3190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f0bdb35
feat: import `.sql` files as text
jacob-ebey May 14, 2022
15e9c84
Merge branch 'dev' into sql-text-import
jacob-ebey Aug 3, 2022
93afee6
Create four-ladybugs-wait.md
jacob-ebey Aug 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/four-ladybugs-wait.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remix-run/dev": patch
---

Allow importing `.sql` files as text
1 change: 1 addition & 0 deletions packages/remix-dev/compiler/loaders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ export const loaders: { [ext: string]: esbuild.Loader } = {
".ogg": "file",
".otf": "file",
".png": "file",
".sql": "text",
Copy link
Member

@sergiodxa sergiodxa May 15, 2022 •
edited by MichaelDeBoey
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
".sql": "text",
".sql": "text",
".gql": "text",

What do you think about also adding .gql as text? That will let people import a .gql file with a GraphQL query/mutation/subscription and then use it as a variable directly in their code

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do a separate PR for that.

".svg": "file",
".ts": "ts",
".tsx": "tsx",
Expand Down