Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(remix-dev): fix typos in server-build.ts' error message #3345

Merged
merged 2 commits into from
Jun 1, 2022
Merged

fix(remix-dev): fix typos in server-build.ts' error message #3345

merged 2 commits into from
Jun 1, 2022

Conversation

RATIU5-zz
Copy link
Contributor

No description provided.

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 31, 2022

Hi @RATIU5,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 31, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour machour changed the title Updated grammer in server-build.ts fix(remix-dev): fix typos in server-build.ts error message May 31, 2022
@MichaelDeBoey MichaelDeBoey changed the title fix(remix-dev): fix typos in server-build.ts error message fix(remix-dev): fix typos in server-build.ts' error message May 31, 2022
kentcdodds
kentcdodds approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit c5fbde7 into remix-run:dev Jun 1, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2022

🤖 Hello there,

We just published version v0.0.0-nightly-d2a375f-20220601 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

justjavac pushed a commit to justjavac/remix that referenced this pull request Jun 11, 2022
@RATIU5 @justjavac
fix(remix-dev): fix typos in server-build.ts' error message (remix-…
9fe159b 
…run#3345)
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v1.6.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

This was referenced Aug 4, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees

@kentcdodds kentcdodds

Labels
CLA Signed package:dev
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RATIU5-zz @kentcdodds @MichaelDeBoey @RATIU5