Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(examples/firebase-auth-firestore): Fix imports and throw meaningful errors when missing .env #3352

Closed
wants to merge 2 commits into from
Closed

fix(examples/firebase-auth-firestore): Fix imports and throw meaningful errors when missing .env #3352

wants to merge 2 commits into from

Commits on Jun 1, 2022

  1. Fix Firebase example 

    Apply fixes as per comment by @mocon at remix-run#1811 (comment)

Also:

- throw meaningul errors when environment variables are missing or can't be parsed.
- check for existence of environment variable rather than cast to string
    @penx
    penx committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    68ea9ed View commit details
    Browse the repository at this point in the history

  2. Add penx to contributors

    @penx
    penx committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    4318468 View commit details
    Browse the repository at this point in the history