feat(remix-vercel): add support for @vercel/node v2

[mcansh]

Closes: #

• Docs
• Tests

Testing Strategy:

[MichaelDeBoey]

We already have #3412

[mcansh]

yup didnt see it 🙈

[MichaelDeBoey]

@mcansh We have permission from @styfle to not wait for approval of his employer and re-open & merge this one

I think we should update @vercel/node in devDependencies too though.

[MichaelDeBoey]

@mcansh Seems like build & tests are failing. Probably need to re-generate yarn.lock

[mcansh]

@mcansh Seems like build & tests are failing. Probably need to re-generate yarn.lock

caused by our test using an internal vercel/node module, looking into it

[MichaelDeBoey]

Seems like vercel/vercel#7931 is causing the build to fail 😕

[mcansh]

looks like @vercel/node uses @vercel/build-utils but it's not in its regular dependencies 👀

yup, like you said 🙈

[MichaelDeBoey]

Created vercel/vercel#7934 to fix it

CC/ @styfle since you're on the Vercel team, you can probably merge that for us please?

[styfle]

How about installing @vercel/build-utils to your devDependencies?

[MichaelDeBoey]

@styfle It's used by @vercel/node, so that package should have it in dependencies

[MichaelDeBoey]

@mcansh @vercel/node@2.2.0 is released now 🥳🎉

[MichaelDeBoey]

@styfle It seems like @vercel/build-utils is missing @vercel/frameworks & @vercel/routing-utils in it's dependencies list.
https://github.com/remix-run/remix/runs/6924983939?check_suite_focus=true#step:6:124

Error: node_modules/@vercel/build-utils/dist/detect-builders.d.ts(1,23): error TS2307: Cannot find module '@vercel/routing-utils' or its corresponding type declarations.
Error: node_modules/@vercel/build-utils/dist/detect-framework.d.ts(1,27): error TS2307: Cannot find module '@vercel/frameworks' or its corresponding type declarations.
Error: node_modules/@vercel/build-utils/dist/workspaces/workspace-managers.d.ts(1,32): error TS2307: Cannot find module '@vercel/frameworks' or its corresponding type declarations.
Error: node_modules/@vercel/build-utils/dist/monorepos/monorepo-managers.d.ts(1,32): error TS2307: Cannot find module '@vercel/frameworks' or its corresponding type declarations.

I however think it would be better to remove @vercel/build-utils from @vercel/node instead tbh.

[MichaelDeBoey]

Waiting for vercel/vercel#7951 (comment) to be resolved

[styfle]

Can you add them as devDependencies as a temporary workaround? We probably won't be able to refactor @vercel/build-utils today since it will take thorough planning and review.

[MichaelDeBoey]

@styfle We've reverted changes to templates/vercel for now and we'll wait until everything is fixed in @vercel/node before we add support for v2

[MichaelDeBoey]

@mcansh @vercel/node@2.3.3 is released now 🥳🎉

Don't forget to update yarn.lock as well.

[MichaelDeBoey]

@mcansh @vercel/node@2.4.0 is released now 🥳🎉

Don't forget to update yarn.lock as well.

[changeset-bot]

🦋 Changeset detected

Latest commit: 66a4333

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
@remix-run/vercel	Patch
remix	Patch
@remix-run/dev	Patch
@remix-run/eslint-config	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/cloudflare	Patch
@remix-run/node	Patch
@remix-run/deno	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
create-remix	Patch
@remix-run/architect	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[kentcdodds]

Sweet! Thanks 👍

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-3c6c798-20220713 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!