-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(examples): add file upload to S3 example #3433
Conversation
* Implemented S3 upload * Updated README * Cleaned up dependencies
* Implemented S3 upload * Updated README * Cleaned up dependencies
Hi @gst4r, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! Thank you for taking the time to put this together. Could you make one change?
* Implemented S3 upload * Updated README * Updated README * Cleaned up dependencies * Fixed dependencies * Refactored from useActionData to useFetcher
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
* S3 file upload (#1) * Implemented S3 upload * Updated README * Cleaned up dependencies * Revert "S3 file upload (#1)" (remix-run#2) This reverts commit df2359c. * S3 file upload (#3) * Implemented S3 upload * Updated README * Cleaned up dependencies * Update contributors.yml * S3 file upload (remix-run#4) * Implemented S3 upload * Updated README * Updated README * Cleaned up dependencies * Fixed dependencies * Refactored from useActionData to useFetcher
Since no example on the internet seemed to handle
AsyncIterable
correctly, I decided to create a simple example on how to upload a file to an S3 bucket. This example is based on the cloudinary one.