Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api/conventions): Fix broken routing guide link #3631

Merged
merged 2 commits into from
Jul 2, 2022

Conversation

manan30
Copy link
Contributor

@manan30 manan30 commented Jul 1, 2022

Closes: #3630

  • Docs
  • Tests

Testing Strategy: Local testing for docs

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 1, 2022

Hi @manan30,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 1, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@machour machour added the docs label Jul 2, 2022
@machour machour changed the title Fix for broken routing guide link on api/conventions page docs(api/conventions): Fix broken routing guide link Jul 2, 2022
@machour machour merged commit 67083e5 into remix-run:main Jul 2, 2022
@machour machour mentioned this pull request Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Routing guide link is broken on the api/conventions page
2 participants