Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(jokes-tutorial): Fix broken route filename convention link #3813

Merged
merged 2 commits into from
Jul 21, 2022
Merged

docs(jokes-tutorial): Fix broken route filename convention link #3813

merged 2 commits into from
Jul 21, 2022

Conversation

alextes
Copy link
Contributor

@alextes alextes commented Jul 21, 2022

Simple docs change.

I believe this should do it. Took a while to figure out with the magical remark processing of the docs files. Hard to be sure.

This is the page the link should go to: https://remix.run/docs/en/v1/api/conventions#route-file-conventions

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 31fec4f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 21, 2022

Hi @alextes,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@alextes
Copy link
Contributor Author

alextes commented Jul 21, 2022

fine CLA bot 😩

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jul 21, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour machour changed the title Fix docs broken route filename convention link docs(jokes-tutorial): Fix broken route filename convention link Jul 21, 2022
@machour machour added the docs label Jul 21, 2022
kentcdodds
kentcdodds approved these changes Jul 21, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kentcdodds kentcdodds merged commit 1443cb8 into remix-run:main Jul 21, 2022
@alextes alextes deleted the patch-1 branch July 21, 2022 12:11
dvargas92495 pushed a commit to dvargas92495/remix that referenced this pull request Jul 22, 2022
@alextes @dvargas92495
docs(jokes-tutorial): Fix broken route filename convention link (remi…
27760c0 
…x-run#3813)

* docs: broken route filename convention link

* chore: sign CLA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

@machour machour machour approved these changes

Assignees

@kentcdodds kentcdodds

Labels
CLA Signed docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alextes @machour @kentcdodds