Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bug-report-template): Remove unnecessary async #3834

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

vincecao
Copy link
Contributor

Closes: NA

  • Docs
  • Tests

Testing Strategy:

I found this unnecessary async in the bug report template. There are some linting rules against this, like no-async-without-await. If this is a team preference please feel free to close it :D.

@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2022

⚠️ No Changeset found

Latest commit: 78cd49b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vincecao vincecao changed the title chore(issue-template): Remove unnecessary async in bug report test template chore(bug-report-template): Remove unnecessary async Jul 25, 2022
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure 👍 Thanks

@kentcdodds kentcdodds merged commit 2904482 into remix-run:dev Jul 26, 2022
@vincecao vincecao deleted the chore/unneeded-async-in-template branch July 26, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants