Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorials/blog): fix links to MDN #3939

Merged
merged 2 commits into from
Aug 6, 2022

Conversation

philandstuff
Copy link
Contributor

mdn.io/request goes to https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods
which isn't what we want.

mdn.io/Request goes to https://developer.mozilla.org/en-US/docs/Web/API/Request
which is what we actually want here.

mdn.io/request.formData and mdn.io/Request.formData both redirect to the same place,
but I updated this link to match the other fix.

mdn.io/request goes to https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods
which isn't what we want.

mdn.io/Request goes to https://developer.mozilla.org/en-US/docs/Web/API/Request
which is what we actually want here.

mdn.io/request.formData and mdn.io/Request.formData both redirect to the same place,
but I updated this link to match the other fix.
@changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2022

⚠️ No Changeset found

Latest commit: 1edd266

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 5, 2022

Hi @philandstuff,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 5, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title Fix links to mdn.io/Request docs(tutorials/blog): fix links to MDN Aug 6, 2022
@MichaelDeBoey MichaelDeBoey requested review from mcansh and machour August 6, 2022 09:58
@MichaelDeBoey MichaelDeBoey merged commit efb3e7f into remix-run:main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants