-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(remix-react): switch name
& content
position in meta
tags
#3953
Conversation
When we visualize the html meta tags on a browswer inspector, I think it's better to see ```html <meta name="twitter:card" content="summary"> ``` than ```html <meta content="summary" name="twitter:card"> ```
|
Hi @arnaudambro, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@kentcdodds This is purely cosmetics, but always have bothered me too :) |
name
& content
position in meta
tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I personally wouldn't merge this one as this is indeed purely cosmetic, but I can see a value if a lot of people are bothered by this.
I didn't get this comment :) This is not purely cosmetic, this is about better debugging, better DX : when you have to go through 50 I know it's not the PR of the year, but... it's a PR improving something, not just cosmetic ! |
I would instinctively do a Going to let the team decide what they want to do with this as I don't want to push my personal opinion/preference for everyone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution.
When we visualize the html meta tags on a browswer inspector, I think it's better to see
than
Closes: #
Testing Strategy: