Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-react): switch name & content position in meta tags #3953

Merged
merged 2 commits into from
Aug 12, 2022

Conversation

arnaudambro
Copy link
Contributor

When we visualize the html meta tags on a browswer inspector, I think it's better to see

<meta name="twitter:card" content="summary">

than

<meta content="summary" name="twitter:card">

Closes: #

  • Docs
  • Tests

Testing Strategy:

When we visualize the html meta tags on a browswer inspector, I think it's better to see
```html
<meta name="twitter:card" content="summary">
```
than
```html
<meta content="summary" name="twitter:card">
```
@changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2022

⚠️ No Changeset found

Latest commit: dd94bb1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 7, 2022

Hi @arnaudambro,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 7, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour machour added the feat:dx Issues related to the developer experience label Aug 7, 2022
@machour
Copy link
Collaborator

machour commented Aug 7, 2022

@kentcdodds This is purely cosmetics, but always have bothered me too :)

@MichaelDeBoey MichaelDeBoey changed the title fix: switch name and content position in meta tags for better dx fix(remix-react): switch name & content position in meta tags Aug 7, 2022
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally wouldn't merge this one as this is indeed purely cosmetic, but I can see a value if a lot of people are bothered by this.

@arnaudambro
Copy link
Contributor Author

I personally wouldn't merge this one as this is indeed purely cosmetic, but I can see a value if a lot of people are bothered by this.

I didn't get this comment :)

This is not purely cosmetic, this is about better debugging, better DX : when you have to go through 50 meta tags and you have content first, whereas you are looking for twitter:image:alt meta tag, then it takes twice as much time if the order is content then name than the opposite.

I know it's not the PR of the year, but... it's a PR improving something, not just cosmetic !

@MichaelDeBoey
Copy link
Member

whereas you are looking for twitter:image:alt meta tag, then it takes twice as much time if the order is content then name than the opposite.

I would instinctively do a CMD + F to search for what I'm looking for, but as I said that's my personal opinion.

Going to let the team decide what they want to do with this as I don't want to push my personal opinion/preference for everyone.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

@kentcdodds kentcdodds merged commit 5987c9e into remix-run:dev Aug 12, 2022
@MichaelDeBoey MichaelDeBoey added the awaiting release This issue has been fixed and will be released soon label Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting release This issue has been fixed and will be released soon CLA Signed feat:dx Issues related to the developer experience renderer:react
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants