Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples(turborepo): add name and version to workspace projects #3999

Merged
merged 1 commit into from
Aug 15, 2022
Merged

examples(turborepo): add name and version to workspace projects #3999

merged 1 commit into from
Aug 15, 2022

Conversation

mcansh
Copy link
Collaborator

@mcansh mcansh commented Aug 15, 2022 •
edited
Loading

quick follow up to #3984.

tried to be lightweight in what i brought over, but looks like name and version are required for the workspace projects, quick follow up PR inbound

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

⚠️ No Changeset found

Latest commit: 3cbc116

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mcansh mcansh requested a review from kentcdodds August 15, 2022 16:00
kentcdodds
kentcdodds approved these changes Aug 15, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kentcdodds kentcdodds merged commit 1cf23f5 into main Aug 15, 2022
@kentcdodds kentcdodds deleted the logan/turborepo-add-name-and-version branch August 15, 2022 16:02
kayac-chang pushed a commit to kayac-chang/remix that referenced this pull request Sep 3, 2022
@mcansh @kayac-chang
examples(turborepo): add name and version to workspace projects (remi…
491d3e4 
…x-run#3999)
freeman pushed a commit to freeman/remix that referenced this pull request Sep 7, 2022
@mcansh @freeman
examples(turborepo): add name and version to workspace projects (remi…
5f54074 
…x-run#3999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
CLA Signed examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcansh @kentcdodds @MichaelDeBoey