Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fetched item count for simple examples #4003

Merged

Conversation

rkulinski
Copy link
Contributor

In order to prevent bugs related to scrolling with scroll bar use fetched items count instead of all available.

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2022

⚠️ No Changeset found

Latest commit: 3450429

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 15, 2022

Hi @rkulinski,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 15, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. This makes sense. For the best UX, people should be using the advanced example anyway 👍

Thanks a bunch!

@kentcdodds kentcdodds merged commit c5c58fb into remix-run:main Aug 15, 2022
@rkulinski rkulinski deleted the rkulinski/fix-infinite-scroll-examples branch August 15, 2022 21:12
kayac-chang pushed a commit to kayac-chang/remix that referenced this pull request Sep 3, 2022
freeman pushed a commit to freeman/remix that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants