-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(remix-dev): replace xdm
with @mdx-js/mdx
v2
#4054
Conversation
🦋 Changeset detectedLatest commit: 43d47a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @jacobwgillespie, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
Thanks, deasync is very problematic on my side and even more with vercel and node 18. Would be very nice to include in the next release 🙏 |
@jacobwgillespie could you please rebase this on latest |
d1e4378
to
26cbeac
Compare
@machour yep, rebased, thank you! |
@jacobwgillespie I didn't look into it, but there's also Could this replace our own |
Perhaps! I'm not super familiar with Remix's use of MDX internally, mostly just that |
26cbeac
to
45111e0
Compare
Hi @jacobwgillespie! Are you still interested in getting this one merged? If so, please rebase onto latest |
xdm
with @mdx-js/mdx
v2
@MichaelDeBoey Thanks for the ping, I have rebased onto the latest |
d8eade1
to
4a59bad
Compare
I'm not sure why the tests are failing, it's upset about |
Oh I see it, it's the new |
🤖 Hello there, We just published version Thanks! |
This PR addresses issue #1802 -
xdm
is now deprecated, and all functionality has been ported to@mdx-js/mdx
.Closes: #1802
DocsTestsTesting Strategy:
All existing tests pass with
yarn test
. Additionally, I created a playground and verified locally that mdx files still build as expected.