feat(create-remix): Add proxy support in create cli

[freeman]

Closes: #3159

• Docs
• Tests

Testing Strategy:

I tested the built cli behind a proxy and it worked seamlessly.

[changeset-bot]

🦋 Changeset detected

Latest commit: f4f1dc1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages

Name	Type
remix	Patch
@remix-run/dev	Patch
create-remix	Patch
@remix-run/architect	Patch
@remix-run/cloudflare	Patch
@remix-run/cloudflare-pages	Patch
@remix-run/cloudflare-workers	Patch
@remix-run/deno	Patch
@remix-run/eslint-config	Patch
@remix-run/express	Patch
@remix-run/netlify	Patch
@remix-run/node	Patch
@remix-run/react	Patch
@remix-run/serve	Patch
@remix-run/server-runtime	Patch
@remix-run/vercel	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @freeman,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[freeman]

slightly simplified the code by having a single agent for the whole file

[freeman]

Let me know if I should do something to get this merged.

This is adding friction to get remix adopted at work :)

[mcansh]

thanks for taking this on @freeman! i've had this on my backlog for far too long 😅. looks good to me on first glance

[freeman]

Working out the test failures

[freeman]

Issues appears only in test with msw because agent-base has a pretty fragile logic for determining the agent protocol

https://github.com/TooTallNate/node-agent-base/blob/c011b2b8efc8de6d57600c459d49baa4c608b86b/src/index.ts#L15-L19

This logic breaks under msw because it overrides the normal node request processing (for good reasons !).

I saw 2 paths to fix this:

• add some logic to ensure the agent protocol is set correctly based on the target url (even if in theory this is not needed outside of the test harness)
• find a way to bypass using the agent at all if under test harness

I went with the first option as some people noted that the logic of relying on stack trace could be broken in future node versions (TooTallNate/node-agent-base#63).

[freeman]

@mcansh could you approve the workflow run if you're ok with the changes to allow tests to pass ?

[mcansh]

@freeman thanks again! do you know if it would be possible to add a test for this new behavior? I haven't worked much behind a proxy 😅

[freeman]

@mcansh I'll take a look but this seems complex to test. I'd need to spin up a temporary proxy server (this seems doable, there is a proxy package) and try to ensure it has been used without breaking the encapsulation...

[freeman]

@mcansh added a basic test that verifies that proxy env variable is honored.

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-eebaa56-20221013 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!