Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(api/remix): fix typo #4268

Merged
merged 2 commits into from
Sep 24, 2022
Merged

docs(api/remix): fix typo #4268

merged 2 commits into from
Sep 24, 2022

Conversation

runofthemill
Copy link
Contributor

Assuming the code block here is accurate, this fixes the reference in the note, as readData does not take an expires arg, but createData does! :)

Fix reference in note about the expires argument to the CRUD methods of createSessionStorage
@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022

⚠️ No Changeset found

Latest commit: c7d3819

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 23, 2022

Hi @runofthemill,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 23, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title Update remix.md docs(api/remix): fix typo Sep 24, 2022
@MichaelDeBoey MichaelDeBoey merged commit 2262dd9 into remix-run:main Sep 24, 2022
@runofthemill runofthemill deleted the patch-1 branch September 24, 2022 03:03
kentcdodds pushed a commit that referenced this pull request Dec 15, 2022
* Update remix.md

Fix reference in note about the expires argument to the CRUD methods of createSessionStorage

* Update contributors.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants