-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add flat routes convention #4716
Conversation
🦋 Changeset detectedLatest commit: 5811b13 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Ok, here's my initial PR. I simply copied over my flatRoutes function. I will work on integrating with existing config and updating the tests. |
@ryanflorence regarding the flag name, did you reach a conclusion regarding keeping or removing the current convention in V2? (Question raised in the RFC) We may want to change the flag name to |
@ryanflorence ok so the plan is if the feature flag is true for flat routes, then this will automatically use the flat routes convention instead of the default (i.e., no need to specify the |
Let's move forward as if this is the only built-in convention for v2, so let's use As folks start updating we can revisit if it maybe shouldn't be the only convention, or even the default. I suspect people will prefer it, though. |
d5442c8
to
f9de2f6
Compare
Integrates flat routes function into config
f9de2f6
to
9ed4a24
Compare
Ok, I've pushed the latest version. This also includes the hybrid routes. I think this gives you the best of both worlds. You can still organize with nested folders, but you also get colocation. |
@kiliman Tested hybrid routes on 0.5.0, works like a charm 👌🏼 Thank you so much for this. |
closed in favor of #4880 (which includes these commits) |
Closes: #4483
This is the initial PR to add flat routes convention
Testing Strategy: