Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(route/headers): Fix incorrect link on headers #4910

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

Deanmv
Copy link
Contributor

@Deanmv Deanmv commented Dec 19, 2022

handledatarequest link was a 404 as it has a the trailing .tsx on the URL

`handledatarequest` link was a 404 as it has a the trailing `.tsx` on the URL
@machour
Copy link
Collaborator

machour commented Dec 19, 2022

Thank you @Deanmv, would you mind signing the CLA by adding your GH username to the contributors.yml file? 🙏🏼

@machour machour added the docs label Dec 19, 2022
@Deanmv
Copy link
Contributor Author

Deanmv commented Dec 19, 2022

@machour it is already in there from a previous docs fix (https://github.com/remix-run/remix/blob/main/contributors.yml#L98) Although the casing looks incorrect, does that matter?

Previous PR where I accepted it for reference - #4170

@machour
Copy link
Collaborator

machour commented Dec 19, 2022

Mm, weird, the CLA bot is blocked this time.
Could you try update casing to match?

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2022

⚠️ No Changeset found

Latest commit: aa0d40d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 19, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@machour machour merged commit 3120d89 into remix-run:main Dec 19, 2022
@mcansh
Copy link
Collaborator

mcansh commented Dec 19, 2022

Although the casing looks incorrect, does that matter?

we .toLowerCase() both your username and all contributors in the file, odd that it didn't make it through this time... but i'll keep an eye out if it happens again :)

staylor pushed a commit to staylor/remix that referenced this pull request Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants