Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakey firefox tests #4912

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Fix flakey firefox tests #4912

merged 3 commits into from
Dec 19, 2022

Conversation

brophdawg11
Copy link
Contributor

Fix some flakey tests in the feat/rrr-rendering branch before merging to dev

@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: b2d8827

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

brophdawg11
brophdawg11 commented Dec 19, 2022
View reviewed changes
integration/error-boundary-test.ts
'<p id="parent-error">Broken!</p>'
);
expect(await app.getHtml("#parent-matches-data")).toEqual(
'<p id="parent-matches-data"></p>'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I think this is a bug in TM today that is fixed in the new router. When JS is enabled, TM doesn't clear out the prior parent routeData so we still get a now-stale PARENT here even though the loader was not re-run

@brophdawg11 brophdawg11 merged commit fc5b75e into feat/rrr-rendering Dec 19, 2022
@brophdawg11 brophdawg11 deleted the brophdawg11/rrr-flakey branch December 19, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@brophdawg11