-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mark Vanilla Extract files as side effects #5246
fix: mark Vanilla Extract files as side effects #5246
Conversation
🦋 Changeset detectedLatest commit: dcc3b66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
Fixes: #5238
Testing Strategy:
I added integration tests for side-effect imports of Vanilla Extract files, both within the app context and within the Vanilla Extract child compilation since it's a separate esbuild pass. I've confirmed that these tests fail when the fix hasn't been applied.