Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark Vanilla Extract files as side effects #5246

Merged
merged 4 commits into from
Jan 25, 2023

Conversation

markdalgleish
Copy link
Member

Fixes: #5238

  • Docs
  • Tests

Testing Strategy:

I added integration tests for side-effect imports of Vanilla Extract files, both within the app context and within the Vanilla Extract child compilation since it's a separate esbuild pass. I've confirmed that these tests fail when the fix hasn't been applied.

@markdalgleish markdalgleish added bug Something isn't working package:dev labels Jan 25, 2023
@changeset-bot
Copy link

changeset-bot bot commented Jan 25, 2023

🦋 Changeset detected

Latest commit: dcc3b66

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
@remix-run/css-bundle Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish merged commit c9ff7ef into dev Jan 25, 2023
@markdalgleish markdalgleish deleted the markdalgleish/vanilla-extract-side-effects branch January 25, 2023 06:28
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jan 25, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-c9ff7ef-20230125 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot removed the awaiting release This issue has been fixed and will be released soon label Jan 30, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.12.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CLA Signed package:dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants