Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add reference to Fastly's runtime #5370

Merged
merged 9 commits into from
Feb 24, 2023

Conversation

harmony7
Copy link
Contributor

@harmony7 harmony7 commented Feb 6, 2023

Now that #4841 has been merged, it will be possible to use Fastly's runtime/adapter/templates on the next release. Thanks all.

As suggested in #4860 (comment), I've made a new PR that adds Fastly's adapter to docs as a community contribution.

These are docs-only, so it's been branched from the main branch.

EDIT: I've removed the docs updates about the runtime / template, this PR is about the adapter only.

@changeset-bot
Copy link

changeset-bot bot commented Feb 6, 2023

⚠️ No Changeset found

Latest commit: 357673b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 6, 2023

Hi @harmony7,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@harmony7 harmony7 force-pushed the harmony7/fastly-runtime-adapter-doc branch from ed5de24 to 3b36d21 Compare February 6, 2023 03:08
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 6, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour machour changed the title Add Fastly runtime / adapter / template to docs docs: Add Fastly runtime / adapter / template Feb 6, 2023
@machour machour added the docs label Feb 6, 2023
@MichaelDeBoey MichaelDeBoey changed the title docs: Add Fastly runtime / adapter / template docs: add reference to Fastly's adapter/runtime/template Feb 6, 2023
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a reference to Fastly's adapter/runtime/template @harmony7! 🙏

I do have some concerns though, so leaving those to the team to decide on.

docs/other-api/adapter.md Outdated Show resolved Hide resolved
docs/pages/community.md Outdated Show resolved Hide resolved
docs/pages/stacks.md Outdated Show resolved Hide resolved
packages/remix-server-runtime/README.md Outdated Show resolved Hide resolved
@harmony7
Copy link
Contributor Author

harmony7 commented Feb 7, 2023

@MichaelDeBoey @machour have made updates:

  • alphabetized list of adapters
  • removed list of stacks and runtimes.

@harmony7 harmony7 requested review from MichaelDeBoey and removed request for brophdawg11 and mcansh February 8, 2023 23:34
@harmony7
Copy link
Contributor Author

harmony7 commented Feb 8, 2023

@MichaelDeBoey oof, I re-requested review from you and I didn't realize that would remove the requests for @brophdawg11 and @mcansh. can you add them back in?

@harmony7 harmony7 changed the title docs: add reference to Fastly's adapter/runtime/template docs: add reference to Fastly's runtime Feb 24, 2023
@harmony7
Copy link
Contributor Author

harmony7 commented Feb 24, 2023

@MichaelDeBoey bump

I've already gotten one approval, but can I get a re-review from you?

What else is needed to get this merged? It would be very nice to be added to the list. =)

@mcansh mcansh merged commit f5236c1 into remix-run:main Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants