Remove fetcher.type/fetcher.submission #5716
Conversation
🦋 Changeset detectedLatest commit: 04b6ba6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 18 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
force-pushed
the
brophdawg11/remove-use-transition
branch
from
af955aa
to
ccdb039
Compare
brophdawg11
force-pushed
the
brophdawg11/remove-fetcher-type-submission
branch
from
4d3e2e8
to
5719710
Compare
| data, | ||
| formMethod: formMethod.toUpperCase() as FormMethod, |
There was a problem hiding this comment.
Small back-compat layer to preserve the Remix uppercase FormMethod on useFetcher
brophdawg11
force-pushed
the
brophdawg11/remove-fetcher-type-submission
branch
from
9d92955
to
b00a959
Compare
| Remove back-compat layer for `useFetcher`/`useFetchers`. This includes a few small breaking changes: | ||
| * `fetcher.type` has been removed since it can be derived from other available information | ||
| * "Submission" fields have been flattened from `fetcher.submission` down onto the root `fetcher` object, and prefixed with `form` in some cases (`fetcher.submission.action` => `fetcher.formAction`) | ||
| * `<fetcher.Form method="get">` is now more accurately categorized as `state:"loading"` instead of `state:"submitting"` to better align with the underlying GET request |
There was a problem hiding this comment.
These are technically breaking since they happened in the same API and there's no flag that applied these changes. Is this something small enough we can call it out in the release notes? Or would it be worth a quick v2_fetcher flag to add this behavior into v1?
We did not have this issue on useTransition/useNavigation because it was a new hook introducing the changed behavior.
| let fetcher: FetcherStates["Loading"] = { | ||
| state, | ||
| data, | ||
| formMethod: formMethod?.toUpperCase() as FormMethod, |
There was a problem hiding this comment.
We still need this back-compat to align to the old uppercase format of formMethod. Separately we should figure out how to get RR to use uppercase so this can be removed, but that currently would be a breaking change in RR.
brophdawg11
force-pushed
the
brophdawg11/remove-fetcher-type-submission
branch
from
b00a959
to
04b6ba6
Compare
MichaelDeBoey
added
the
BREAKING CHANGE
v2once RemoveuseTransitionin favor ofuseNavigation#5689 is mergedRemoves
fetcher.typeandfetcher.submissionfor v2. We still keep a small back-compat layer for now since there's an unintentional mismatch in casing betweenformMethodon RemixuseFetcher/useTransitionversus react RouteruseFetcher/useNavigation