Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(remix-dev) Custom port note #623

Merged
merged 7 commits into from
Mar 18, 2022
Merged

Conversation

TheRealFlyingCoder
Copy link
Contributor

I think this should be a config variable, but for now at least we can show how to set it manually

I think this should be a config variable, but for now at least we can show how to set it manually
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 25, 2021

Hi @TheRealFlyingCoder,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Nov 25, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@ryanflorence
Copy link
Member

does it need the cross-env?

Also might want to note that REMIX_DEV_SERVER_WS_PORT if you want to change that too (which you will if you're trying to run two apps with remix dev at the same time.

@ryanflorence ryanflorence added the needs-response We need a response from the original author about this issue/PR label Feb 11, 2022
It wasn't necessary, just needed to state that the PORT env variable was available
@TheRealFlyingCoder
Copy link
Contributor Author

does it need the cross-env?

It did not, i've updated to be more generic :)

Also might want to note that REMIX_DEV_SERVER_WS_PORT if you want to change that too (which you will if you're trying to run two apps with remix dev at the same time.

Mentioned, and linked to the relevant doc 👍

@github-actions github-actions bot removed the needs-response We need a response from the original author about this issue/PR label Feb 13, 2022
@machour machour added the docs label Mar 18, 2022
@machour machour merged commit 590dc2f into remix-run:main Mar 18, 2022
@machour machour changed the title remix dev - Custom port note docs(remix-dev) Custom port note Mar 18, 2022
F3n67u pushed a commit to F3n67u/remix that referenced this pull request Mar 21, 2022
Co-authored-by: Ryan Florence <rpflorence@gmail.com>
Co-authored-by: Mehdi Achour <machour@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants