Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wrangler to v3 in cloudflare-pages template #6436

Closed

Conversation

Jackardios
Copy link

@Jackardios Jackardios commented May 20, 2023

Closes: #6415

In addition to updating wrangler to v3, I also removed wrangler.toml (since it is not supported by wrangler pages dev) and added the latest compatibility-date as an option to invoke the wrangler pages dev command

@changeset-bot
Copy link

changeset-bot bot commented May 20, 2023

⚠️ No Changeset found

Latest commit: 41796f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 20, 2023

Hi @Jackardios,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented May 20, 2023

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@huw
Copy link
Contributor

huw commented May 23, 2023

Related to #6229—probably better to just propose these changes there. Would be helpful to upgrade Wrangler in the Workers Sites template, also.

@MichaelDeBoey
Copy link
Member

Thanks for taking the time to implement these changes @Jackardios!

Could you please add these changes as suggestions on #6229 instead?
Going to close this as we don't need to have another PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants