Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-react): fix fetcher.formEncType #6810

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix(remix-react): fix fetcher.formEncType #6810

merged 2 commits into from
Jul 11, 2023

Conversation

AlemTuzlak
Copy link
Contributor

I believe that there is a typing issue with fetchers where the encType is not typed correctly, I noticed this when using useNavigate where the hook was typed but the fetcher wasn't so I tracked it down and fixed it.

Testing Strategy:

Import useFetcher or useFetchers
The type of formEncType should be FormEncType | undefined instead of string | undefined

@changeset-bot
Copy link

changeset-bot bot commented Jul 11, 2023

🦋 Changeset detected

Latest commit: b4590bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/react Patch
@remix-run/testing Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AlemTuzlak
Copy link
Contributor Author

@brophdawg11 hopfully I did it right this time, last PR was from the main branch and I couldn't change the origin but only the target

@machour machour requested a review from brophdawg11 July 11, 2023 11:14
@MichaelDeBoey MichaelDeBoey changed the title fix(remix-react): fix fetcher.formEncType fix(remix-react): fix fetcher.formEncType Jul 11, 2023
@brophdawg11
Copy link
Contributor

Thanks!

@brophdawg11 brophdawg11 merged commit 27deda5 into remix-run:dev Jul 11, 2023
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-c8936ac-20230712 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 1.19.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants