Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): websocket heartbeat #6926

Closed
wants to merge 1 commit into from
Closed

Conversation

pcattori
Copy link
Contributor

Applies changes in #6904 to both dev servers (old and new) and targets dev branch

@changeset-bot
Copy link

changeset-bot bot commented Jul 21, 2023

🦋 Changeset detected

Latest commit: 6c33e62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11
Copy link
Contributor

brophdawg11 commented Jul 21, 2023

We don't need to PR this to dev, it'll get there when we merge release-hotfix in. But do we need to make the v2 changes (packages/remix-dev/devServer_unstable/socket.ts) in release-hotfix?

@brophdawg11
Copy link
Contributor

nvm - Jason has a PR to main that has it - #6927. I'm going to close this and both updates will make it to dev with the release

@brophdawg11 brophdawg11 deleted the pedro/websocket-heartbeat branch July 21, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants