Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-netlify): show deprecation warning on usage #6937

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Jul 22, 2023

Just like we did with the Vercel adapter

We should probably release this as 1.19.2 so people still get this warning before v2 🤔

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2023

🦋 Changeset detected

Latest commit: e547a79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/netlify Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/css-bundle Patch
@remix-run/deno Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/testing Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey force-pushed the show-deprecation-warning-on-netlify-adapter-usage branch 4 times, most recently from f71418f to 66ad399 Compare July 31, 2023 14:12
@brophdawg11
Copy link
Contributor

@MichaelDeBoey Agreed - let's get this rebased onto main so we can include in a 1.19.2

@MichaelDeBoey MichaelDeBoey force-pushed the show-deprecation-warning-on-netlify-adapter-usage branch from 66ad399 to 3ae5572 Compare August 1, 2023 18:01
@MichaelDeBoey MichaelDeBoey changed the base branch from dev to main August 1, 2023 18:01
@MichaelDeBoey
Copy link
Member Author

@brophdawg11 Should be fine now

@brophdawg11 brophdawg11 changed the base branch from main to release-hotfix August 2, 2023 15:06
@brophdawg11 brophdawg11 merged commit 1ac0452 into remix-run:release-hotfix Aug 2, 2023
@MichaelDeBoey MichaelDeBoey deleted the show-deprecation-warning-on-netlify-adapter-usage branch August 2, 2023 15:15
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

🤖 Hello there,

We just published version 1.19.2-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-7cb1e7e-20230803 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🤖 Hello there,

We just published version 1.19.2-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🤖 Hello there,

We just published version 1.19.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

eastlondoner pushed a commit to eastlondoner/remix that referenced this pull request Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants