Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove v1 meta API #6958

Merged
merged 14 commits into from
Jul 31, 2023
Merged

feat!: remove v1 meta API #6958

merged 14 commits into from
Jul 31, 2023

Conversation

markdalgleish
Copy link
Member

Replay of #5796 against current dev.

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 4d50ffc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@remix-run/cloudflare Major
@remix-run/deno Major
@remix-run/dev Major
@remix-run/node Major
@remix-run/react Major
@remix-run/server-runtime Major
@remix-run/testing Major
@remix-run/cloudflare-pages Major
@remix-run/cloudflare-workers Major
@remix-run/architect Major
@remix-run/express Major
@remix-run/netlify Major
@remix-run/serve Major
@remix-run/vercel Major
create-remix Major
remix Major
@remix-run/css-bundle Major
@remix-run/eslint-config Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@markdalgleish markdalgleish marked this pull request as ready for review July 26, 2023 05:21
@markdalgleish markdalgleish changed the title feat: remove v1 meta API feat!: remove v1 meta API Jul 27, 2023
@markdalgleish markdalgleish self-assigned this Jul 27, 2023
MichaelDeBoey
MichaelDeBoey requested changes Jul 29, 2023
View reviewed changes
docs/guides/styling.md Outdated Show resolved Hide resolved
docs/route/meta-v2.md Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can just remove this file, just like we did with all other *-v2 files already?

Copy link
Member Author

@markdalgleish markdalgleish Jul 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's a good idea to leave this manual redirect here as a placeholder until we organise a proper redirect on the Remix website, which we can't do until after the v2 docs go live.

packages/remix-server-runtime/__tests__/handler-test.ts Show resolved Hide resolved
MichaelDeBoey
MichaelDeBoey requested changes Jul 31, 2023
View reviewed changes
docs/route/meta.md Outdated Show resolved Hide resolved
@markdalgleish @MichaelDeBoey
Update docs/route/meta.md
16c2664 
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@markdalgleish markdalgleish merged commit 3855242 into dev Jul 31, 2023
9 checks passed
@markdalgleish markdalgleish deleted the markdalgleish/remove-v1-meta branch July 31, 2023 23:18
@github-actions github-actions bot added the awaiting release This issue has been fixed and will be released soon label Jul 31, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Aug 1, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-7dfbd88-20230801 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-3b808ce-20230802 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

🤖 Hello there,

We just published version 1.19.2-pre.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 3, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-7cb1e7e-20230803 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

🤖 Hello there,

We just published version 1.19.2-pre.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-6e250f7-20230805 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

🤖 Hello there,

We just published version v0.0.0-nightly-a179aa7-20230809 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request Aug 28, 2023
Merged
@KarelVerschraegen KarelVerschraegen mentioned this pull request Sep 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brophdawg11 brophdawg11 brophdawg11 approved these changes

@MichaelDeBoey MichaelDeBoey Awaiting requested review from MichaelDeBoey

Assignees

@markdalgleish markdalgleish

Labels
awaiting release This issue has been fixed and will be released soon BREAKING CHANGE This change will require a major version bump CLA Signed package:dev package:remix package:server-runtime package:testing renderer:react runtime:cloudflare runtime:deno runtime:node template:architect template:cloudflare-pages template:cloudflare-workers template:deno template:express template:fly template:netlify template:remix template:remix-javascript template:vercel v2 Issues related to v2 apis
Projects
No open projects
v2
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@markdalgleish @brophdawg11 @MichaelDeBoey