-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove abort-controller
dependency
#7044
chore: remove abort-controller
dependency
#7044
Conversation
|
f3c8d6e
to
0b3cb8f
Compare
0b3cb8f
to
2c966b4
Compare
@brophdawg11 Adding We have these in #6108 as well, but I'm not sure how we should handle them though 🤔 |
@brophdawg11 I managed to (temporarily) "fix" the type error with Let's discuss there if this is an approach we like or not |
b6f3998
to
a1b97e6
Compare
I rebased this branch on #6108 to have passing tests, but that one should be merged first before merging this one |
2a3da84
to
d112278
Compare
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
🤖 Hello there, We just published version Thanks! |
AbortSignal
is stable as of Node v15.4https://nodejs.org/api/globals.html#class-abortcontroller
This PR is relying on #6108, so that one needs to be merged first