-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(templates/express): dynamically import chokidar
so it doesn't crash production
#7078
Conversation
|
3f652bd
to
6ac06fa
Compare
chokidar
isn't needed in production
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this into main
+ we should probably also update dev_v2 docs with this
As a template change I agree this should go to |
92fd4d5
to
7ad07bd
Compare
rebased!
edit: the following did the trick without too much effort pbcopy < ./templates/express/server.js
git checkout main
git pull
git checkout -
git reset main --hard
pbpaste > ./templates/express/server.js
git rebase --onto main dev (git branch --show-current) --committer-date-is-author-date
git push --force-with-lease |
7ad07bd
to
c9f3791
Compare
chokidar
isn't needed in productionchokidar
so it doesn't crash production
prior to this change if you built the remix app, pruned dev only dependencies and attempted to `npm start` the server would bail as it tried to import chokidar Signed-off-by: Logan McAnsh <logan@mcan.sh>
c9f3791
to
2a0c53e
Compare
prior to this change if you built the remix app, pruned dev only dependencies and attempted to
npm start
the server would bail as it tried to import chokidarCloses: #
Testing Strategy: