-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: stop passing isTypeScript
to remix.init
script
#7099
feat!: stop passing isTypeScript
to remix.init
script
#7099
Conversation
🦋 Changeset detectedLatest commit: 7eeb408 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was deliberately left in as a backwards compatibility layer for existing templates. If we do this, we might want to fast-follow the v2 release with some PRs to community templates that rely on this flag. |
@markdalgleish I'm happy to create PRs for our stacks + the official Netlify & Vercel templates (if needed) I can also do the top 10 listed repos with |
4f8e5ec
to
1275207
Compare
IIRC we would prefer to remove remix init entirely eventually? Is there a large benefit to removing this flag? It sounds like it just creates a bunch more work for us (per #7099 (comment)) so curious if the the juice is worth the squeeze? |
Imo it makes it more clear to template/stack creators that we're not supporting JS transpilation anymore so that they have to provide a JS version themselves if they want to support that |
0a9e7fe
to
8545f0e
Compare
I looked into removing it as part of the new |
I would say: the longer we keep it, more templates/stacks can start to rely on it, so more templates/stacks will need an update to remove it from their codebase |
I'm on board with whatever you guys think - you've got more context than I do here - just want to avoid creating any unnecessary work :). I don't think updating the top 10 community stacks is totally necessary if we've got this clearly called out as a breaking change in v2, but if the LOE is small than it could be a nice addition. |
Then I would just merge this one |
b648947
to
d8d92cb
Compare
Yep, let's merge it. |
dadade5
to
7eeb408
Compare
🤖 Hello there, We just published version Thanks! |
Follow-up of @markdalgleish's #6887