refactor!(serve): remove undocumented createApp node api
#7229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e25658d The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
pcattori
changed the title
createApp node apicreateApp node api
pcattori
force-pushed
the
pedro/remix-serve-cli-only
branch
from
1e352a4
to
aa6db4d
Compare
pcattori
commented
Aug 22, 2023
| @@ -1,11 +1,19 @@ | |||
| import "./env"; | |||
There was a problem hiding this comment.
I inlined code from ./env and ./index into this file
remix-serve should be a CLI, not a Node library
pcattori
force-pushed
the
pedro/remix-serve-cli-only
branch
from
aa6db4d
to
e25658d
Compare
jacob-ebey
approved these changes
Aug 22, 2023
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
|
🤖 Hello there, We just published version Thanks! |
joglr
added a commit
to git-truck/git-truck
that referenced
this pull request
Nov 10, 2023
Fixes #673 See this breaking change from Remix for context: remix-run/remix#7229
joglr
added a commit
to git-truck/git-truck
that referenced
this pull request
Nov 12, 2023
Fixes #673 See this breaking change from Remix for context: remix-run/remix#7229
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remix-serve should be a CLI, not a Node library
Testing Strategy:
Existing integration tests + tested locally with
LOCAL_BUILD_DIRECTORY